Skip to content

Added host argument#1901

Merged
devoncarew merged 2 commits into
flutter:masterfrom
Raieen:master
May 19, 2020
Merged

Added host argument#1901
devoncarew merged 2 commits into
flutter:masterfrom
Raieen:master

Conversation

@Raieen
Copy link
Copy Markdown
Contributor

@Raieen Raieen commented May 3, 2020

Hi,

This pull request adds a new command line argument, host. This allows a user to specify the host they want DevTools to run on and defaults to localhost if the host is not passed in.

Currently there is no way to change to change the host for DevTools as it defaults to localhost. Since this feature exists for Dart Observatory (i.e. --enable-vm-service=8181/0.0.0.0), it would be nice to have the same feature in DevTools.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Raieen
Copy link
Copy Markdown
Contributor Author

Raieen commented May 3, 2020

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Copy Markdown
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Raieen
Copy link
Copy Markdown
Contributor Author

Raieen commented May 16, 2020

Hi, it looks like one of the tests is failing due to

Unable to connect to Chrome debug port: 39187
   SocketException: OS Error: Connection refused, errno = 111, address = localhost, port = 59818

If the test runs again and passes, is there any action on me to get this merged in?

@devoncarew
Copy link
Copy Markdown
Contributor

That failure is likely unrelated to the PR. Can you update this PR with the latest from master and re-push to your branch? That will kick off the tests again (and make sure this works with the latest source from master). Thanks!

@devoncarew
Copy link
Copy Markdown
Contributor

@Raieen - the CIs are green now; merging. Thanks for the contribution!

@devoncarew devoncarew merged commit ad033fb into flutter:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants